From 3f98e17215101b1a8651f7753e956f7989b8b0f2 Mon Sep 17 00:00:00 2001
From: xue jiahao <hsuehchiahao@gmail.com>
Date: Wed, 20 Nov 2024 13:47:34 +0800
Subject: [PATCH 1/2] [feature] add new application

---
 frontend/src/components/AppSelectBox.vue |  24 ++++-
 frontend/src/components/ShowDialog.vue   |   7 +-
 frontend/src/pages/AppManagement.vue     | 112 +++++++++++++++++++----
 3 files changed, 117 insertions(+), 26 deletions(-)

diff --git a/frontend/src/components/AppSelectBox.vue b/frontend/src/components/AppSelectBox.vue
index 9680e97..a887449 100644
--- a/frontend/src/components/AppSelectBox.vue
+++ b/frontend/src/components/AppSelectBox.vue
@@ -17,28 +17,38 @@
   </div>
 </template>
 <script lang="ts">
-import { ref, onMounted, reactive, watchEffect } from 'vue'
+import { ref, onMounted, reactive, watchEffect, PropType } from 'vue'
 import { api } from 'boot/axios';
 
+interface IAppDisplay {
+  id: string;
+  name: string;
+  description: string;
+  createdate: string;
+}
+
 export default {
   name: 'AppSelectBox',
   props: {
     name: String,
     type: String,
     filter: String,
+    filterInitRowsFunc: {
+      type: Function as PropType<(app: IAppDisplay) => boolean>,
+    },
     updateSelectApp: {
       type: Function
     }
   },
   setup(props) {
     const columns = [
-      { name: 'id', required: true, label: 'ID', align: 'left', field: 'id', sortable: true },
+      { name: 'id', required: true, label: 'ID', align: 'left', field: 'id', sortable: true, sort: (a: string, b: string) => parseInt(a, 10) - parseInt(b, 10) },
       { name: 'name', label: 'アプリ名', field: 'name', sortable: true, align: 'left' },
       { name: 'description', label: '概要', field: 'description', align: 'left', sortable: false },
       { name: 'createdate', label: '作成日時', field: 'createdate', align: 'left' }
     ]
     const isLoaded = ref(false);
-    const rows: any[] = reactive([]);
+    const rows = reactive<IAppDisplay[]>([]);
     const selected = ref([])
 
     watchEffect(()=>{
@@ -49,12 +59,16 @@ export default {
     onMounted(() => {
       api.get('api/v1/allapps').then(res => {
         res.data.apps.forEach((item: any) => {
-          rows.push({
+          const row : IAppDisplay = {
             id: item.appId,
             name: item.name,
             description: item.description,
             createdate: dateFormat(item.createdAt)
-          });
+          }
+          if (props.filterInitRowsFunc && !props.filterInitRowsFunc(row)) {
+            return;
+          }
+          rows.push(row);
         });
         isLoaded.value = true;
       });
diff --git a/frontend/src/components/ShowDialog.vue b/frontend/src/components/ShowDialog.vue
index ab6cd0a..50641db 100644
--- a/frontend/src/components/ShowDialog.vue
+++ b/frontend/src/components/ShowDialog.vue
@@ -12,7 +12,7 @@
          <slot></slot>
         </q-card-section>
         <q-card-actions v-if="!disableBtn" align="right" class="text-primary">
-          <q-btn flat label="確定" v-close-popup @click="CloseDialogue('OK')" />
+          <q-btn flat label="確定" :loading="okBtnLoading" :v-close-popup="okBtnAutoClose" @click="CloseDialogue('OK')" />
           <q-btn flat label="キャンセル" v-close-popup @click="CloseDialogue('Cancel')" />
         </q-card-actions>
       </q-card>
@@ -30,6 +30,11 @@ export default {
     height:String,
     minWidth:String,
     minHeight:String,
+    okBtnLoading:Boolean,
+    okBtnAutoClose:{
+      type: Boolean,
+      default: true
+    },
     disableBtn:{
       type: Boolean,
       default: false
diff --git a/frontend/src/pages/AppManagement.vue b/frontend/src/pages/AppManagement.vue
index 3ee1737..ac70edb 100644
--- a/frontend/src/pages/AppManagement.vue
+++ b/frontend/src/pages/AppManagement.vue
@@ -8,7 +8,7 @@
     <q-table title="Treats" :rows="rows" :columns="columns" row-key="id" :filter="filter" :loading="loading" :pagination="pagination">
 
       <template v-slot:top>
-        <q-btn disabled color="primary" :disable="loading" label="新規" @click="addRow" />
+        <q-btn color="primary" :disable="loading" label="新規" @click="showAddAppDialog" />
         <q-space />
         <q-input borderless dense filled debounce="300" v-model="filter" placeholder="検索">
           <template v-slot:append>
@@ -32,9 +32,18 @@
           </q-btn-group>
         </q-td>
       </template>
-
     </q-table>
 
+    <show-dialog v-model:visible="showSelectApp" name="アプリ選択" @close="closeSelectAppDialog" min-width="50vw" min-height="50vh" :ok-btn-auto-close="false" :ok-btn-loading="isAdding">
+      <template v-slot:toolbar>
+        <q-input dense debounce="300" v-model="filter" placeholder="検索" clearable>
+          <template v-slot:before>
+            <q-icon name="search" />
+          </template>
+        </q-input>
+      </template>
+      <app-select-box ref="appDialog" name="アプリ" type="single" :filter="filter" :filterInitRowsFunc="filterInitRows" />
+    </show-dialog>
   </div>
 </template>
 
@@ -46,9 +55,12 @@ import { useFlowEditorStore } from 'stores/flowEditor';
 import { router } from 'src/router';
 import { date } from 'quasar'
 import { IManagedApp } from 'src/types/AppTypes';
+import ShowDialog from 'src/components/ShowDialog.vue';
+import AppSelectBox from 'src/components/AppSelectBox.vue';
 
 interface IAppDisplay{
   id:string;
+  sortId: number;
   name:string;
   url:string;
   user:string;
@@ -58,36 +70,38 @@ interface IAppDisplay{
 
 const authStore = useAuthStore();
 const numberStringSorting = (a: string, b: string) => parseInt(a, 10) - parseInt(b, 10);
+const addedRowHighlightClass = (row: IAppDisplay) => row.id === addedRowId.value ? 'highlight-row' : '';
 
 const columns = [
-  { name: 'id', label: 'アプリID', field: 'id', align: 'left', sortable: true, sort: numberStringSorting },
-  { name: 'name', label: 'アプリ名', field: 'name', align: 'left', sortable: true },
-  { name: 'url', label: 'URL', field: 'url', align: 'left', sortable: true },
-  { name: 'user', label: '最後更新者', field: 'user', align: 'left', sortable: true},
-  { name: 'updatetime', label: '最後更新日', field: 'updatetime', align: 'left', sortable: true},
-  { name: 'version', label: 'バージョン', field: 'version', align: 'left', sortable: true},
-  { name: 'actions', label: '操作', field: 'actions' }
+  { name: 'id', label: 'アプリID', field: 'id', align: 'left', sortable: true, sort: numberStringSorting, classes: addedRowHighlightClass },
+  { name: 'name', label: 'アプリ名', field: 'name', align: 'left', sortable: true, classes: addedRowHighlightClass },
+  { name: 'url', label: 'URL', field: 'url', align: 'left', sortable: true, classes: addedRowHighlightClass },
+  { name: 'user', label: '最後更新者', field: 'user', align: 'left', sortable: true, classes: addedRowHighlightClass},
+  { name: 'updatetime', label: '最後更新日', field: 'updatetime', align: 'left', sortable: true, classes: addedRowHighlightClass },
+  { name: 'version', label: 'バージョン', field: 'version', align: 'left', sortable: true, sort: numberStringSorting, classes: addedRowHighlightClass },
+  { name: 'actions', label: '操作', field: 'actions', classes: addedRowHighlightClass }
 ];
 
 const pagination = ref({ sortBy: 'id', descending: true, rowsPerPage: 20 });
 const loading = ref(false);
 const filter = ref('');
 const rows = ref<IAppDisplay[]>([]);
+const rowIds = new Set<string>();
+
 const store = useFlowEditorStore();
+const appDialog = ref();
+const showSelectApp=ref(false);
+const isAdding = ref(false);
+const addedRowId = ref('');
 
 const getApps = async () => {
   loading.value = true;
+  rowIds.clear();
   const result = await api.get('api/apps');
   rows.value = result.data.map((item: IManagedApp) => {
-    return {
-      id: item.appid,
-      name: item.appname,
-      url: `${item.domainurl}/k/${item.appid}`,
-      user: `${item.user.first_name} ${item.user.last_name}` ,
-      updatetime:date.formatDate(item.update_time, 'YYYY/MM/DD HH:mm'),
-      version: Number(item.version)
-    }
-  }).sort((a: IAppDisplay, b: IAppDisplay) => numberStringSorting(a.id, b.id)); // set default order
+    rowIds.add(item.appid);
+    return appToAppDisplay(item)
+  }).sort((a: IAppDisplay, b: IAppDisplay) => a.sortId - b.sortId); // set default order
   loading.value = false;
 }
 
@@ -100,8 +114,44 @@ watch(() => authStore.currentDomain.id, async () => {
   await getApps();
 });
 
-const addRow = () => {
-  return
+const filterInitRows = (row: {id: string}) => {
+  return !rowIds.has(row.id);
+}
+
+const showAddAppDialog = () => {
+  showSelectApp.value = true;
+}
+
+const closeSelectAppDialog = async (val: 'OK'|'Cancel') => {
+  showSelectApp.value = true;
+  if (val == 'OK' && appDialog.value.selected[0]) {
+      isAdding.value = true;
+      const data  = appDialog.value.selected[0];
+      const appInfo = {
+        domainurl: authStore.currentDomain.kintoneUrl,
+        appid: data.id ,
+        appname: data.name
+      };
+      const result = await api.post('api/apps', appInfo);
+      const item = result?.data;
+      if (item) {
+        // binarysearch is better
+        const newItem = appToAppDisplay(item)
+        const index = rows.value.findIndex(element => element.sortId >= newItem.sortId);
+        if (index === -1) {
+          rows.value.push(newItem);
+        } else {
+          rows.value.splice(index, 0, newItem);
+        }
+        rowIds.add(newItem.id);
+        addedRowId.value = newItem.id;
+        setTimeout(() => {
+          addedRowId.value = ''
+        }, 2000);
+      }
+  }
+  showSelectApp.value = false;
+  isAdding.value = false;
 }
 
 const removeRow = (app:IAppDisplay) => {
@@ -112,6 +162,18 @@ const showHistory = (app:IAppDisplay) => {
   return
 }
 
+const appToAppDisplay = (app: IManagedApp) => {
+  return {
+    id: app.appid,
+    sortId: parseInt(app.appid, 10),
+    name: app.appname,
+    url: `${app.domainurl}/k/${app.appid}`,
+    user: `${app.user.first_name} ${app.user.last_name}` ,
+    updatetime:date.formatDate(app.update_time, 'YYYY/MM/DD HH:mm'),
+    version: app.version
+  }
+}
+
 const editFlow = (app:IAppDisplay) => {
   store.setApp({
     appId: app.id,
@@ -121,3 +183,13 @@ const editFlow = (app:IAppDisplay) => {
   router.push('/FlowChart/' + app.id);
 };
 </script>
+<style lang="scss">
+.q-table td.highlight-row {
+  animation: breathe 0.6s ease-in-out 2 forwards;
+}
+@keyframes breathe {
+  0% { background-color: #ffffff; }
+  50% { background-color: #fffde7; }
+  100% { background-color: #ffffff; }
+}
+</style>
\ No newline at end of file

From bf4abe3cade7ea8728adc178a19c483c5641a0c1 Mon Sep 17 00:00:00 2001
From: xue jiahao <hsuehchiahao@gmail.com>
Date: Wed, 20 Nov 2024 16:04:40 +0800
Subject: [PATCH 2/2] Fix select app

---
 frontend/src/pages/AppManagement.vue | 56 ++++++----------------------
 frontend/src/pages/FlowChart.vue     | 18 ++++++++-
 2 files changed, 27 insertions(+), 47 deletions(-)

diff --git a/frontend/src/pages/AppManagement.vue b/frontend/src/pages/AppManagement.vue
index ac70edb..99d960d 100644
--- a/frontend/src/pages/AppManagement.vue
+++ b/frontend/src/pages/AppManagement.vue
@@ -26,7 +26,7 @@
       <template v-slot:body-cell-actions="p">
         <q-td :props="p">
           <q-btn-group flat>
-            <q-btn flat color="primary" padding="xs" size="1em" icon="edit_note" @click="editFlow(p.row)" />
+            <q-btn flat color="primary" padding="xs" size="1em" icon="edit_note" @click="toEditFlowPage(p.row)" />
             <q-btn disabled flat color="primary" padding="xs" size="1em" icon="history" @click="showHistory(p.row)" />
             <q-btn disabled flat color="negative" padding="xs" size="1em" icon="delete_outline" @click="removeRow(p.row)" />
           </q-btn-group>
@@ -70,16 +70,15 @@ interface IAppDisplay{
 
 const authStore = useAuthStore();
 const numberStringSorting = (a: string, b: string) => parseInt(a, 10) - parseInt(b, 10);
-const addedRowHighlightClass = (row: IAppDisplay) => row.id === addedRowId.value ? 'highlight-row' : '';
 
 const columns = [
-  { name: 'id', label: 'アプリID', field: 'id', align: 'left', sortable: true, sort: numberStringSorting, classes: addedRowHighlightClass },
-  { name: 'name', label: 'アプリ名', field: 'name', align: 'left', sortable: true, classes: addedRowHighlightClass },
-  { name: 'url', label: 'URL', field: 'url', align: 'left', sortable: true, classes: addedRowHighlightClass },
-  { name: 'user', label: '最後更新者', field: 'user', align: 'left', sortable: true, classes: addedRowHighlightClass},
-  { name: 'updatetime', label: '最後更新日', field: 'updatetime', align: 'left', sortable: true, classes: addedRowHighlightClass },
-  { name: 'version', label: 'バージョン', field: 'version', align: 'left', sortable: true, sort: numberStringSorting, classes: addedRowHighlightClass },
-  { name: 'actions', label: '操作', field: 'actions', classes: addedRowHighlightClass }
+  { name: 'id', label: 'アプリID', field: 'id', align: 'left', sortable: true, sort: numberStringSorting },
+  { name: 'name', label: 'アプリ名', field: 'name', align: 'left', sortable: true },
+  { name: 'url', label: 'URL', field: 'url', align: 'left', sortable: true },
+  { name: 'user', label: '最後更新者', field: 'user', align: 'left', sortable: true},
+  { name: 'updatetime', label: '最後更新日', field: 'updatetime', align: 'left', sortable: true},
+  { name: 'version', label: 'バージョン', field: 'version', align: 'left', sortable: true, sort: numberStringSorting },
+  { name: 'actions', label: '操作', field: 'actions' }
 ];
 
 const pagination = ref({ sortBy: 'id', descending: true, rowsPerPage: 20 });
@@ -92,7 +91,6 @@ const store = useFlowEditorStore();
 const appDialog = ref();
 const showSelectApp=ref(false);
 const isAdding = ref(false);
-const addedRowId = ref('');
 
 const getApps = async () => {
   loading.value = true;
@@ -126,29 +124,7 @@ const closeSelectAppDialog = async (val: 'OK'|'Cancel') => {
   showSelectApp.value = true;
   if (val == 'OK' && appDialog.value.selected[0]) {
       isAdding.value = true;
-      const data  = appDialog.value.selected[0];
-      const appInfo = {
-        domainurl: authStore.currentDomain.kintoneUrl,
-        appid: data.id ,
-        appname: data.name
-      };
-      const result = await api.post('api/apps', appInfo);
-      const item = result?.data;
-      if (item) {
-        // binarysearch is better
-        const newItem = appToAppDisplay(item)
-        const index = rows.value.findIndex(element => element.sortId >= newItem.sortId);
-        if (index === -1) {
-          rows.value.push(newItem);
-        } else {
-          rows.value.splice(index, 0, newItem);
-        }
-        rowIds.add(newItem.id);
-        addedRowId.value = newItem.id;
-        setTimeout(() => {
-          addedRowId.value = ''
-        }, 2000);
-      }
+      toEditFlowPage(appDialog.value.selected[0]);
   }
   showSelectApp.value = false;
   isAdding.value = false;
@@ -174,7 +150,7 @@ const appToAppDisplay = (app: IManagedApp) => {
   }
 }
 
-const editFlow = (app:IAppDisplay) => {
+const toEditFlowPage = (app:IAppDisplay) => {
   store.setApp({
     appId: app.id,
     name: app.name
@@ -182,14 +158,4 @@ const editFlow = (app:IAppDisplay) => {
   store.selectFlow(undefined);
   router.push('/FlowChart/' + app.id);
 };
-</script>
-<style lang="scss">
-.q-table td.highlight-row {
-  animation: breathe 0.6s ease-in-out 2 forwards;
-}
-@keyframes breathe {
-  0% { background-color: #ffffff; }
-  50% { background-color: #fffde7; }
-  100% { background-color: #ffffff; }
-}
-</style>
\ No newline at end of file
+</script>
\ No newline at end of file
diff --git a/frontend/src/pages/FlowChart.vue b/frontend/src/pages/FlowChart.vue
index 2c0d150..d0ecce1 100644
--- a/frontend/src/pages/FlowChart.vue
+++ b/frontend/src/pages/FlowChart.vue
@@ -328,8 +328,22 @@ const fetchData = async () => {
 }
 
 const fetchAppById = async(id: string) => {
-  const result = await api.get('api/apps');
-  return result.data.find((item: IManagedApp) => item.appid === id ) as IManagedApp;
+  try {
+    const result = await api.get('api/apps');
+    return result.data.find((item: IManagedApp) => item.appid === id ) as IManagedApp;
+  } catch (e) {
+    console.error(e);
+    const result = await api.get(`api/v1/app?app=${id}`);
+    const data = result?.data;
+    if (data?.message) {
+      $q.notify({
+        type: 'negative',
+        caption: "エラー",
+        message: data.message
+      });
+    }
+    return { appid: data.appId, appname: data.name };
+  }
 }
 
 const onClearFilter=()=>{